[Clang] Lift HIPSPV onto the new offload driver (WIP) #168043
Draft
+85
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuber6
reviewed
Nov 14, 2025
| break; | ||
| case llvm::Triple::spirv32: | ||
| case llvm::Triple::spirv64: | ||
| if (Target.getOSName() == "hipspv" || |
Contributor
There was a problem hiding this comment.
Why do we need this here? The linker wrapper passes --target=spirv64-amd-amdhsa which keys off of the HSA OS above. Do we need separate handling?
Contributor
Author
There was a problem hiding this comment.
Not sure what is being asked here. chipStar utilizes HIPSPV TC which is achieved by keying off with the spirv*-*-chipstar triple.
| OPT_v, | ||
| OPT_cuda_path_EQ, | ||
| OPT_rocm_path_EQ, | ||
| OPT_hip_path_EQ, |
Contributor
There was a problem hiding this comment.
Is the HIP path really different from the rocm path? Figured those would just be aliases.
Contributor
Author
There was a problem hiding this comment.
Not necessarily? HIP is a subset of ROCm and I think that HIP is a subdirectory in ROCm installations so --hip-path != --rocm-path.
| A->getValue(1))); | ||
| } | ||
| Args.ClaimAllArgs(options::OPT_Xoffload_linker); | ||
| Args.ClaimAllArgs(options::OPT_Xoffload_compiler); |
Contributor
Author
There was a problem hiding this comment.
My mistake - I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing HIPSPV toolchain to support
--offload-new-driver.TODOs: